> Bug in baseline ShortestPath solution?

I attempted to run the ShortestPath solution against provided test scenarios and I was consistently running into an error in airlift/solutions/baselines.py line 61. "dones" was None and so "dones[a]" was throwing an unhandled exception.
I did not get an error running the RandomAgent solution.
I was able to get ShortestPath to work by changing line 61 to check for None first:

if dones is not None and dones[a]:

Is it possible I messed up on my environment setup? Or is it correct that "dones" can be None?

Posted by: doug-l @ Jan. 16, 2023, 8:42 p.m.

To clarify, I ran into this issue when using the ShortestPath solution against the test scenarios downloaded from here: https://airliftchallenge.com/scenarios/scenarios_dev.zip
There was no error when running airlift-demo .

Posted by: doug-l @ Jan. 16, 2023, 9:47 p.m.

Thank you for raising this issue with us.

I'm going to look into it today by doing a fresh install and run with those scenarios. We did have this issue previously but thought we addressed it by either checking for it in our Solution or initializing all values to False. I'm glad that in the short term you were able to get past this problem.

Posted by: adelanovic @ Jan. 18, 2023, 1:39 p.m.

This issue was fixed and pushed to the repo. Dones was being incorrectly set to None in an evaluator function instead of getting the values from the environment. The change makes it so you don't have to check for None in the shortestpath.
Thanks again!

Posted by: adelanovic @ Jan. 20, 2023, 4:31 p.m.
Post in this thread